Giving Constructive Feedback
You'll learn how to deliver feedback that promotes growth while preserving team trust and psychological safety.
Constructive feedback is a core collaboration skill that separates high-performing teams from dysfunctional ones. When done well, feedback accelerates learning, improves code quality, and strengthens relationships. When done poorly, it damages psychological safety and makes team members defensive or withdrawn.
The Core Principles
Effective feedback focuses on behavior and impact, not personality or intent. Instead of saying "You're careless," describe what you observed: "This function doesn't validate input, which could cause crashes in production." This shift keeps the conversation objective and actionable.
Think of feedback like debugging: you identify the symptom, trace it to the specific code line, and suggest a fix—without blaming the compiler or runtime for "being stupid." The same respect applies to people.
The Structure: SBI Framework
Use the Situation-Behavior-Impact pattern:
- Situation: "During yesterday's code review..."
- Behavior: "...you approved the PR without checking the error handling..."
- Impact: "...which led to the bug escaping to staging and delaying the release."
Then add a forward-looking element: "Going forward, could we agree to specifically verify error paths in reviews?"
Maintaining Psychological Safety
Deliver feedback privately when it addresses mistakes, publicly when it praises. Ask permission ("Can I share some feedback on the design discussion?") to respect timing and readiness. Use "I" statements to own your perspective rather than claiming absolute truth.
Remember: feedback is a gift meant to help someone grow, not a weapon to assert superiority.
Key Takeaway: Constructive feedback focuses on observable behaviors and their impact, uses objective language, and aims to help team members improve while maintaining the trust and psychological safety essential for high-performing engineering teams.